Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 818213002: Remove UNREACHABLE() statements from sys-info.cc (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
5 years, 12 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove UNREACHABLE() statements from sys-info.cc We have safe fallbacks in all cases, and it's possible to hit those codepaths, e.g., on Linux when /proc is not mounted BUG=v8:3544 R=ulan@chromium.org LOG=n Committed: https://crrev.com/96143d193143daab45b14cee840f59954d7a1036 Cr-Commit-Position: refs/heads/master@{#25940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/base/sys-info.cc View 7 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-23 13:59:14 UTC) #1
ulan
lgtm
6 years ago (2014-12-23 14:00:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818213002/1
6 years ago (2014-12-23 14:03:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1910)
6 years ago (2014-12-23 14:39:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818213002/1
5 years, 12 months ago (2014-12-23 17:53:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-23 19:25:17 UTC) #9
commit-bot: I haz the power
5 years, 12 months ago (2014-12-23 19:25:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96143d193143daab45b14cee840f59954d7a1036
Cr-Commit-Position: refs/heads/master@{#25940}

Powered by Google App Engine
This is Rietveld 408576698