Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 818203002: [turbofan] Turn IrOpcode::Mnemonic() into a table lookup. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn IrOpcode::Mnemonic() into a table lookup. R=ishell@chromium.org Committed: https://crrev.com/4a8623c637b2847849ecb5a5a76af6809d152e57 Cr-Commit-Position: refs/heads/master@{#25939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -12 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -12 lines 0 comments Download
A src/compiler/opcodes.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
6 years ago (2014-12-23 13:26:16 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-23 13:27:02 UTC) #2
Igor Sheludko
lgtm
6 years ago (2014-12-23 13:46:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818203002/1
6 years ago (2014-12-23 13:49:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 19:24:08 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-23 19:24:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a8623c637b2847849ecb5a5a76af6809d152e57
Cr-Commit-Position: refs/heads/master@{#25939}

Powered by Google App Engine
This is Rietveld 408576698