fpdfsdk/include/javascript/JS_Define.h - Issue 818193004: XFA: merge patch from CL 729293003, use FX_ArraySize for safety

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/JS_Define.h

Issue 818193004: XFA: merge patch from CL 729293003, use FX_ArraySize for safety (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/javascript/JS_Define.h

diff --git a/fpdfsdk/include/javascript/JS_Define.h b/fpdfsdk/include/javascript/JS_Define.h

index 8ead492548b4cc296e3b6e6837883dfe2f9d2f4e..6b7af41d5fa776279a8f64c2c3a04f2ab4fc4643 100644

--- a/fpdfsdk/include/javascript/JS_Define.h

+++ b/fpdfsdk/include/javascript/JS_Define.h

@@ -599,7 +599,7 @@ if (JS_DefineGlobalConst(pRuntime,JS_WIDESTRING(const_name),JS_NewString(pRuntim

/* ======================================== GLOBAL ARRAYS ============================================ */

#define DEFINE_GLOBAL_ARRAY(pRuntime)\

-int size = sizeof(ArrayContent) / sizeof(FX_LPCWSTR);\

+int size = FX_ArraySize(ArrayContent);\

CJS_Array array(pRuntime);\

for (int i=0; i<size; i++) array.SetElement(i,CJS_Value(pRuntime,ArrayContent[i]));\

« no previous file with comments | « core/include/fxcrt/fx_string.h ('k') | fpdfsdk/src/javascript/PublicMethods.cpp » ('j') | no next file with comments »