Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 818123002: Simplify observer_list_threadsafe.h using a variadic template. (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
Reviewers:
mdempsky
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify observer_list_threadsafe.h using a variadic template. Made possible by the new Tuple implementation. No intended behavior change. BUG=440675 Committed: https://crrev.com/662b3e438c6bad207bc4f56ebe9d8e3db9b34e71 Cr-Commit-Position: refs/heads/master@{#309515}

Patch Set 1 #

Patch Set 2 : loop #

Total comments: 2

Patch Set 3 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -45 lines) Patch
M base/observer_list_threadsafe.h View 1 2 2 chunks +14 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
6 years ago (2014-12-22 22:36:05 UTC) #2
mdempsky
lgtm https://codereview.chromium.org/818123002/diff/20001/base/observer_list_threadsafe.h File base/observer_list_threadsafe.h (right): https://codereview.chromium.org/818123002/diff/20001/base/observer_list_threadsafe.h#newcode171 base/observer_list_threadsafe.h:171: void Notify(Method m, Params... params) { Should this ...
6 years ago (2014-12-22 23:23:21 UTC) #3
Nico
Thanks! https://codereview.chromium.org/818123002/diff/20001/base/observer_list_threadsafe.h File base/observer_list_threadsafe.h (right): https://codereview.chromium.org/818123002/diff/20001/base/observer_list_threadsafe.h#newcode171 base/observer_list_threadsafe.h:171: void Notify(Method m, Params... params) { On 2014/12/22 ...
6 years ago (2014-12-22 23:55:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818123002/40001
6 years ago (2014-12-22 23:56:20 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-23 02:03:26 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-23 02:04:04 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/662b3e438c6bad207bc4f56ebe9d8e3db9b34e71
Cr-Commit-Position: refs/heads/master@{#309515}

Powered by Google App Engine
This is Rietveld 408576698