Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: components/variations/variations_seed_processor_unittest.cc

Issue 818103002: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/variations_seed_processor.cc ('k') | components/wallpaper/wallpaper_manager_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/variations_seed_processor_unittest.cc
diff --git a/components/variations/variations_seed_processor_unittest.cc b/components/variations/variations_seed_processor_unittest.cc
index 4252ca9f27c387d856e070790232d1bc2ad8fa01..d1f76ccb00cb973628bd17f619644cfadc5cc725 100644
--- a/components/variations/variations_seed_processor_unittest.cc
+++ b/components/variations/variations_seed_processor_unittest.cc
@@ -136,7 +136,7 @@ class VariationsSeedProcessorTest : public ::testing::Test {
};
TEST_F(VariationsSeedProcessorTest, AllowForceGroupAndVariationId) {
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
base::FieldTrialList field_trial_list(NULL);
@@ -154,7 +154,7 @@ TEST_F(VariationsSeedProcessorTest, AllowForceGroupAndVariationId) {
// Test that the group for kForcingFlag1 is forced.
TEST_F(VariationsSeedProcessorTest, ForceGroupWithFlag1) {
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
base::FieldTrialList field_trial_list(NULL);
@@ -166,7 +166,7 @@ TEST_F(VariationsSeedProcessorTest, ForceGroupWithFlag1) {
// Test that the group for kForcingFlag2 is forced.
TEST_F(VariationsSeedProcessorTest, ForceGroupWithFlag2) {
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag2);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag2);
base::FieldTrialList field_trial_list(NULL);
@@ -178,8 +178,8 @@ TEST_F(VariationsSeedProcessorTest, ForceGroupWithFlag2) {
TEST_F(VariationsSeedProcessorTest, ForceGroup_ChooseFirstGroupWithFlag) {
// Add the flag to the command line arguments so the flag group is forced.
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag2);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag2);
base::FieldTrialList field_trial_list(NULL);
@@ -303,7 +303,7 @@ TEST_F(VariationsSeedProcessorTest, OverrideUIStringsWithForcingFlag) {
override->set_name_hash(1234);
override->set_value("test");
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
base::FieldTrialList field_trial_list(NULL);
EXPECT_TRUE(CreateTrialFromStudy(&study));
EXPECT_EQ(kFlagGroup1Name, base::FieldTrialList::FindFullName(study.name()));
@@ -391,7 +391,7 @@ TEST_F(VariationsSeedProcessorTest, VariationParamsWithForcingFlag) {
param->set_name("x");
param->set_value("y");
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
base::FieldTrialList field_trial_list(NULL);
EXPECT_TRUE(CreateTrialFromStudy(&study));
EXPECT_EQ(kFlagGroup1Name, base::FieldTrialList::FindFullName(study.name()));
@@ -449,7 +449,7 @@ TEST_F(VariationsSeedProcessorTest, StartsActive) {
}
TEST_F(VariationsSeedProcessorTest, StartsActiveWithFlag) {
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
base::FieldTrialList field_trial_list(NULL);
@@ -474,7 +474,7 @@ TEST_F(VariationsSeedProcessorTest, ForcingFlagAlreadyForced) {
base::FieldTrialList field_trial_list(NULL);
base::FieldTrialList::CreateFieldTrial(kFlagStudyName, kNonFlagGroupName);
- CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
+ base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
EXPECT_TRUE(CreateTrialFromStudy(&study));
// The previously forced experiment should still hold.
EXPECT_EQ(kNonFlagGroupName,
« no previous file with comments | « components/variations/variations_seed_processor.cc ('k') | components/wallpaper/wallpaper_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698