Removes tray keyboard icon from the status area.

Removes tray keyboard icon from the status area.

BUG=444655
TEST=TrayKeyboardLockTest.HiddenOnCreation, TrayKeyboardLockTest.HidesOnA11yEnabled, TrayKeyboardLockTest.PerformActionOnDefaultView

Committed: https://crrev.com/05cb187d507e5f5f69b0011e3b87cbba94216435
Cr-Commit-Position: refs/heads/master@{#309470}

[rsadam, 2014-12-22 20:58:45]

rsadam@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2014-12-22 21:21:27]

LGTM

https://codereview.chromium.org/818083002/diff/1/ash/system/chromeos/virtual_...
File ash/system/chromeos/virtual_keyboard/tray_keyboard_lock.cc (right):

https://codereview.chromium.org/818083002/diff/1/ash/system/chromeos/virtual_...
ash/system/chromeos/virtual_keyboard/tray_keyboard_lock.cc:118:
virtual_keyboard_suppressed_ = suppressed;
Side question: instead of also adding KeyboardLockDefaultView as a VKObserver,
why not notify it from here?

[rsadam, 2014-12-22 21:26:35]

https://codereview.chromium.org/818083002/diff/1/ash/system/chromeos/virtual_...
File ash/system/chromeos/virtual_keyboard/tray_keyboard_lock.cc (right):

https://codereview.chromium.org/818083002/diff/1/ash/system/chromeos/virtual_...
ash/system/chromeos/virtual_keyboard/tray_keyboard_lock.cc:118:
virtual_keyboard_suppressed_ = suppressed;
On 2014/12/22 21:21:27, sadrul wrote:
> Side question: instead of also adding KeyboardLockDefaultView as a VKObserver,
> why not notify it from here?

From what I understand, the DefaultView is only created when the user clicks on
the tray to bring it up. I felt that the current approach was cleaner than
checking whether a DefaultView was currently active and updating it. Is this
something I should change?

[sadrul, 2014-12-22 21:32:08]

still lgtm

https://codereview.chromium.org/818083002/diff/1/ash/system/chromeos/virtual_...
File ash/system/chromeos/virtual_keyboard/tray_keyboard_lock.cc (right):

https://codereview.chromium.org/818083002/diff/1/ash/system/chromeos/virtual_...
ash/system/chromeos/virtual_keyboard/tray_keyboard_lock.cc:118:
virtual_keyboard_suppressed_ = suppressed;
On 2014/12/22 21:26:35, rsadam wrote:
> On 2014/12/22 21:21:27, sadrul wrote:
> > Side question: instead of also adding KeyboardLockDefaultView as a
VKObserver,
> > why not notify it from here?
> 
> From what I understand, the DefaultView is only created when the user clicks
on
> the tray to bring it up.

Yes.

> I felt that the current approach was cleaner than
> checking whether a DefaultView was currently active and updating it.

 if (default_view_)
   default_view_->UpdateSuppression(suppressed);

isn't that unclean. The reason I make this suggestion is that we follow this
pattern for a number of the other tray items (e.g. audio, bluetooth, network,
etc.).

> Is this
> something I should change?

Not necessarily (depends on the owner of this particular item; this is more of a
nit), and definitely not in this CL.

[rsadam, 2014-12-22 21:57:51]

On 2014/12/22 21:32:08, sadrul wrote:
> still lgtm
> 
>
https://codereview.chromium.org/818083002/diff/1/ash/system/chromeos/virtual_...
> File ash/system/chromeos/virtual_keyboard/tray_keyboard_lock.cc (right):
> 
>
https://codereview.chromium.org/818083002/diff/1/ash/system/chromeos/virtual_...
> ash/system/chromeos/virtual_keyboard/tray_keyboard_lock.cc:118:
> virtual_keyboard_suppressed_ = suppressed;
> On 2014/12/22 21:26:35, rsadam wrote:
> > On 2014/12/22 21:21:27, sadrul wrote:
> > > Side question: instead of also adding KeyboardLockDefaultView as a
> VKObserver,
> > > why not notify it from here?
> > 
> > From what I understand, the DefaultView is only created when the user clicks
> on
> > the tray to bring it up.
> 
> Yes.
> 
> > I felt that the current approach was cleaner than
> > checking whether a DefaultView was currently active and updating it.
> 
>  if (default_view_)
>    default_view_->UpdateSuppression(suppressed);
> 
> isn't that unclean. The reason I make this suggestion is that we follow this
> pattern for a number of the other tray items (e.g. audio, bluetooth, network,
> etc.).
> 
> > Is this
> > something I should change?
> 
> Not necessarily (depends on the owner of this particular item; this is more of
a
> nit), and definitely not in this CL.

Okay, filed crbug.com/444669 and assigned it to myself.

[rsadam, 2014-12-22 21:58:02]

The CQ bit was checked by rsadam@chromium.org

[commit-bot: I haz the power, 2014-12-22 21:58:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818083002/1

[commit-bot: I haz the power, 2014-12-22 22:11:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-22 22:12:50]

Patchset 1 (id:??) landed as
https://crrev.com/05cb187d507e5f5f69b0011e3b87cbba94216435
Cr-Commit-Position: refs/heads/master@{#309470}