Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 818053003: [Telemetry] Add test that make sure no two benchmarks have the same name (Closed)

Created:
6 years ago by nednguyen
Modified:
5 years, 12 months ago
Reviewers:
sullivan, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add test that make sure no two benchmarks have the same name BUG=441446 Committed: https://crrev.com/687a0081935b3e20449ba6c21603c49fd8c34da1 Cr-Commit-Position: refs/heads/master@{#309562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M tools/perf/benchmarks/benchmark_unittest.py View 4 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
6 years ago (2014-12-23 02:34:24 UTC) #2
sullivan
lgtm Thanks for making sure this doesn't happen again!
5 years, 12 months ago (2014-12-23 15:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818053003/1
5 years, 12 months ago (2014-12-23 15:30:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-23 18:20:09 UTC) #6
commit-bot: I haz the power
5 years, 12 months ago (2014-12-23 18:21:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/687a0081935b3e20449ba6c21603c49fd8c34da1
Cr-Commit-Position: refs/heads/master@{#309562}

Powered by Google App Engine
This is Rietveld 408576698