Issue 818033005: Standardize usage of virtual/override/final specifiers in tools/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 818033005: Standardize usage of virtual/override/final specifiers in tools/. (Closed)

Created:
6 years ago by dcheng

Modified:
6 years ago

Reviewers:
Nico

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove an empty destructor in tool/gn's LoaderTest. Committed: https://crrev.com/53b26086e11e21145588dbd1b8e2f9f622a5f7e1 Cr-Commit-Position: refs/heads/master@{#309483}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	tools/gn/loader_unittest.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818033005/20001

6 years ago (2014-12-22 22:54:59 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-22 23:18:14 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/53b26086e11e21145588dbd1b8e2f9f622a5f7e1
Cr-Commit-Position: refs/heads/master@{#309483}