Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 817983004: Add formatting presubmit checks for all ash/chromeos directory (Closed)

Created:
5 years, 11 months ago by oshima
Modified:
5 years, 11 months ago
Reviewers:
tfarina, James Cook
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add formatting presubmit checks for all ash/chromeos directory BUG=None R=jamescook@chromium.org Committed: https://crrev.com/613d8037d8843b6aaab0da0e095fc39d65c3140e Cr-Commit-Position: refs/heads/master@{#311569}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
A + chrome/browser/chromeos/PRESUBMIT.py View 1 chunk +1 line, -1 line 2 comments Download
A + chrome/browser/ui/ash/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/views/ash/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
A + ui/chromeos/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
oshima
https://codereview.chromium.org/817983004/diff/1/chrome/browser/chromeos/PRESUBMIT.py File chrome/browser/chromeos/PRESUBMIT.py (right): https://codereview.chromium.org/817983004/diff/1/chrome/browser/chromeos/PRESUBMIT.py#newcode5 chrome/browser/chromeos/PRESUBMIT.py:5: """Presubmit script for chromeos. instead of putting full path, ...
5 years, 11 months ago (2015-01-14 20:24:42 UTC) #1
James Cook
LGTM https://codereview.chromium.org/817983004/diff/1/chrome/browser/chromeos/PRESUBMIT.py File chrome/browser/chromeos/PRESUBMIT.py (right): https://codereview.chromium.org/817983004/diff/1/chrome/browser/chromeos/PRESUBMIT.py#newcode5 chrome/browser/chromeos/PRESUBMIT.py:5: """Presubmit script for chromeos. On 2015/01/14 20:24:42, oshima ...
5 years, 11 months ago (2015-01-14 20:45:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817983004/1
5 years, 11 months ago (2015-01-14 22:27:59 UTC) #4
tfarina
Is this code already all formatted by clang-format?
5 years, 11 months ago (2015-01-14 22:57:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 23:22:45 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 23:23:42 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/613d8037d8843b6aaab0da0e095fc39d65c3140e
Cr-Commit-Position: refs/heads/master@{#311569}

Powered by Google App Engine
This is Rietveld 408576698