Issue 8179: Disable the yahoo application state plugin as it crashes the plugin process...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8179: Disable the yahoo application state plugin as it crashes the plugin process... (Closed)

Created:
12 years, 2 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable the yahoo application state plugin as it crashes the plugin process on return from NPObjectStub::OnInvoke. This is because of a bug in the plugin, where in it returns a string in the variant which is not allocated using NPN_MemAlloc. As a result it crashes when we free the memory for the string. It also crashes in Firefox. Firefox 3 disables the plugin. (http://kb.mozillazine.org/Issues_related_to_plugins). We disable this plugin as well. This fixes http://b/issue?id=1362948 R=jam Bug=1362948 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3979

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	webkit/glue/plugins/plugin_list.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

12 years, 2 months ago (2008-10-25 01:48:19 UTC) #2

lgtm

http://codereview.chromium.org/8179/diff/1/2
File webkit/glue/plugins/plugin_list.cc (right):

http://codereview.chromium.org/8179/diff/1/2#newcode194
Line 194: // Disable the yahoo application state plugin.
Can you add a comment about why we're doing this?  Something brief like it
crashes and link to the bug number (even if it's internal).

Expand Messages | Collapse Messages