Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 817873003: Use weak cell in monomorphic KeyedStore IC. (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use weak cell in monomorphic KeyedStore IC. BUG=v8:3629 LOG=N Committed: https://crrev.com/eff42215f08259d9f1329818604866d5467522f7 Cr-Commit-Position: refs/heads/master@{#25923}

Patch Set 1 #

Patch Set 2 : Fix comment #

Patch Set 3 : Fix mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -105 lines) Patch
M src/arm/macro-assembler-arm.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ulan
PTAL
6 years ago (2014-12-22 12:36:40 UTC) #2
Igor Sheludko
lgtm
6 years ago (2014-12-22 12:51:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817873003/20001
6 years ago (2014-12-22 12:55:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817873003/40001
6 years ago (2014-12-22 13:11:03 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-22 13:38:12 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-22 13:38:26 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eff42215f08259d9f1329818604866d5467522f7
Cr-Commit-Position: refs/heads/master@{#25923}

Powered by Google App Engine
This is Rietveld 408576698