Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 817853006: Deflake flights-app.sky. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Deflake flights-app.sky. We need to wait for the images to load. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5b3355d5966fb477ee03743d36e8f265b0805057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -50 lines) Patch
M sky/tests/framework/flights-app.sky View 1 chunk +24 lines, -2 lines 0 comments Download
M sky/tests/framework/flights-app-expected.txt View 4 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 11 months ago (2015-01-16 01:40:10 UTC) #2
ojan
5 years, 11 months ago (2015-01-16 01:40:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b3355d5966fb477ee03743d36e8f265b0805057 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698