Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: src/gpu/GrOvalRenderer.cpp

Issue 817853002: Remove localcoordchange functions off paint (Closed) Base URL: https://skia.googlesource.com/skia.git@local-matrix-on-gp
Patch Set: cleanup Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/GrOvalRenderer.cpp
diff --git a/src/gpu/GrOvalRenderer.cpp b/src/gpu/GrOvalRenderer.cpp
index 304d6d69adea0d60e8e092f488461a93639b600d..6c132f6f8118df7e0dc6ed31bdc6741d903f2af1 100644
--- a/src/gpu/GrOvalRenderer.cpp
+++ b/src/gpu/GrOvalRenderer.cpp
@@ -124,6 +124,7 @@ public:
const BatchTracker& local = bt.cast<BatchTracker>();
const CircleEdgeEffect& circleEffect = processor.cast<CircleEdgeEffect>();
b->add32(circleEffect.isStroked() << 16 | local.fInputColorType);
+ b->add32(local.fUsesLocalCoords && processor.localMatrix().hasPerspective());
bsalomon 2014/12/22 21:13:55 here and the others below, can't we just use a bit
}
virtual void setData(const GrGLProgramDataManager& pdman,
@@ -307,6 +308,7 @@ public:
const BatchTracker& local = bt.cast<BatchTracker>();
const EllipseEdgeEffect& ellipseEffect = processor.cast<EllipseEdgeEffect>();
b->add32(ellipseEffect.isStroked() << 16 | local.fInputColorType);
+ b->add32(local.fUsesLocalCoords && processor.localMatrix().hasPerspective());
}
virtual void setData(const GrGLProgramDataManager& pdman,
@@ -511,6 +513,7 @@ public:
const BatchTracker& local = bt.cast<BatchTracker>();
const DIEllipseEdgeEffect& ellipseEffect = processor.cast<DIEllipseEdgeEffect>();
b->add32(ellipseEffect.getMode() << 16 | local.fInputColorType);
+ b->add32(local.fUsesLocalCoords && processor.localMatrix().hasPerspective());
}
virtual void setData(const GrGLProgramDataManager& pdman,
@@ -1086,7 +1089,7 @@ bool GrOvalRenderer::drawDRRect(GrDrawTarget* target,
if (applyAA) {
bounds.outset(SK_ScalarHalf, SK_ScalarHalf);
}
- target->drawRect(drawState, color, bounds, NULL, NULL);
+ target->drawSimpleRect(drawState, color, bounds);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698