Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: runtime/vm/disassembler_arm.cc

Issue 817823002: Add inlining ranges/intervals to code objects so that we can map a pc to the inlined stack. The map… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/disassembler.cc ('k') | runtime/vm/disassembler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_arm.cc
===================================================================
--- runtime/vm/disassembler_arm.cc (revision 42521)
+++ runtime/vm/disassembler_arm.cc (working copy)
@@ -1532,39 +1532,6 @@
}
}
-
-void Disassembler::Disassemble(uword start,
- uword end,
- DisassemblyFormatter* formatter,
- const Code::Comments& comments) {
- ASSERT(formatter != NULL);
- char hex_buffer[kHexadecimalBufferSize]; // Instruction in hexadecimal form.
- char human_buffer[kUserReadableBufferSize]; // Human-readable instruction.
- uword pc = start;
- intptr_t comment_finger = 0;
- while (pc < end) {
- const intptr_t offset = pc - start;
- while (comment_finger < comments.Length() &&
- comments.PCOffsetAt(comment_finger) <= offset) {
- formatter->Print(
- " ;; %s\n",
- String::Handle(comments.CommentAt(comment_finger)).ToCString());
- comment_finger++;
- }
- int instruction_length;
- DecodeInstruction(hex_buffer, sizeof(hex_buffer),
- human_buffer, sizeof(human_buffer),
- &instruction_length, pc);
-
- formatter->ConsumeInstruction(hex_buffer,
- sizeof(hex_buffer),
- human_buffer,
- sizeof(human_buffer),
- pc);
- pc += instruction_length;
- }
-}
-
} // namespace dart
#endif // defined TARGET_ARCH_ARM
« no previous file with comments | « runtime/vm/disassembler.cc ('k') | runtime/vm/disassembler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698