WebSocket layout tests clean up

WebSocket layout tests clean up

Adding onerror in Websocket LayoutTests.

BUG=233487
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188293

[Paritosh Kumar, 2015-01-09 04:55:00]

paritosh.in@samsung.com changed reviewers:
+ tyoshino@chromium.org

[Paritosh Kumar, 2015-01-09 04:55:01]

Please have a look on the cahnge, added onerror() in WebSocket LayoutTests.

[tyoshino (SeeGerritForStatus), 2015-01-13 05:31:53]

Thanks for increasing event test coverage!

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/compressed-control-frame.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/compressed-control-frame.html:38:
debug("onerror() was called");
Let's use testPassed

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/fragmented-control-frame.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/fragmented-control-frame.html:38:
debug("onerror() was called.");
Let's use testPassed, and remove "." to align with shouldBeFalse()'s output

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-404.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-404.html:34:
testPassed("onerror called");
onerror() was called

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-extensions-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-extensions-header.html:33:
testPassed("onerror called");
onerror() was called

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html:49:
debug("onerror() was called.");
let's use testPassed, and remove ".".

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File
LayoutTests/http/tests/websocket/handshake-fail-by-mismatch-protocol-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-mismatch-protocol-header.html:45:
testPassed("onerror called.");
onerror() was called

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-more-accept-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-more-accept-header.html:40:
debug("Error.");
testPassed("onerror() was called.");

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File
LayoutTests/http/tests/websocket/handshake-fail-by-more-protocol-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-more-protocol-header.html:40:
testPassed("onerror called");
onerror() was called

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-no-accept-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-accept-header.html:33:
testPassed("onerror called.");
onerror() was called

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File
LayoutTests/http/tests/websocket/handshake-fail-by-no-connection-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-connection-header.html:25:
debug("FAIL: Connected");
Let's just also replace this with

testFailed("Unexpectedly Connected.");

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-connection-header.html:41:
debug("PASS: Onerror Called");
testPassed("onerror() was called");

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-no-upgrade-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-upgrade-header.html:25:
debug("FAIL: Connected");
testFailed("Unexpectedly Connected.");

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-upgrade-header.html:41:
debug("PASS: onerror called");
testPassed("onerror() was called");

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null.html:49:
debug("onerror() was called");
testPassed

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-wrong-accept-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-wrong-accept-header.html:33:
testPassed("onerror called.");
onerror() was called

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/interleaved-fragments.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/interleaved-fragments.html:38: debug("onerror()
was called.");
Let's use testPassed, and remove ".".

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/invalid-continuation.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/invalid-continuation.html:38: debug("onerror
was called.");
onerror() was called

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/invalid-encode-length.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/invalid-encode-length.html:49: debug("onerror()
was called.");
Let's use testPassed, and remove ".".

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/invalid-masked-frames-from-server.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/invalid-masked-frames-from-server.html:38:
debug("onerror() was called.");
Let's use testPassed, and remove ".".

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/long-control-frame.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/long-control-frame.html:33: debug("onerror()
was called");
Let's use testPassed

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/long-invalid-header.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/long-invalid-header.html:29: debug("Error
occured");
testPassed("onerror() was called");

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/permessage-deflate-invalid-parameter.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/permessage-deflate-invalid-parameter.html:51:
testPassed("onerror() was called.");
Remove "." to align with shouldBeFalse()'s output

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/reserved-bits.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/reserved-bits.html:53: testPassed("onerror()
was called.");
Remove "."

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/reserved-opcodes.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/reserved-opcodes.html:53: testPassed("onerror()
was called.");
Remove "."

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/too-long-payload.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/too-long-payload.html:38: testPassed("onerror()
was called.");
Remove "."

[Paritosh Kumar, 2015-01-13 10:19:41]

Patchset #2 (id:20001) has been deleted

[Paritosh Kumar, 2015-01-13 10:19:55]

Patchset #2 (id:40001) has been deleted

[Paritosh Kumar, 2015-01-13 10:20:29]

Thanks tyoshino.

Done. PTAL.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/compressed-control-frame.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/compressed-control-frame.html:38:
debug("onerror() was called");
On 2015/01/13 05:31:49, tyoshino wrote:
> Let's use testPassed

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/fragmented-control-frame.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/fragmented-control-frame.html:38:
debug("onerror() was called.");
On 2015/01/13 05:31:49, tyoshino wrote:
> Let's use testPassed, and remove "." to align with shouldBeFalse()'s output

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-404.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-404.html:34:
testPassed("onerror called");
On 2015/01/13 05:31:49, tyoshino wrote:
> onerror() was called

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-extensions-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-extensions-header.html:33:
testPassed("onerror called");
On 2015/01/13 05:31:49, tyoshino wrote:
> onerror() was called

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html:49:
debug("onerror() was called.");
On 2015/01/13 05:31:50, tyoshino wrote:
> let's use testPassed, and remove ".".

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File
LayoutTests/http/tests/websocket/handshake-fail-by-mismatch-protocol-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-mismatch-protocol-header.html:45:
testPassed("onerror called.");
On 2015/01/13 05:31:50, tyoshino wrote:
> onerror() was called

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-more-accept-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-more-accept-header.html:40:
debug("Error.");
On 2015/01/13 05:31:50, tyoshino wrote:
> testPassed("onerror() was called.");

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File
LayoutTests/http/tests/websocket/handshake-fail-by-more-protocol-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-more-protocol-header.html:40:
testPassed("onerror called");
On 2015/01/13 05:31:52, tyoshino wrote:
> onerror() was called

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-no-accept-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-accept-header.html:33:
testPassed("onerror called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> onerror() was called

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File
LayoutTests/http/tests/websocket/handshake-fail-by-no-connection-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-connection-header.html:25:
debug("FAIL: Connected");
On 2015/01/13 05:31:52, tyoshino wrote:
> Let's just also replace this with
> 
> testFailed("Unexpectedly Connected.");

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-connection-header.html:41:
debug("PASS: Onerror Called");
On 2015/01/13 05:31:52, tyoshino wrote:
> testPassed("onerror() was called");

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-no-upgrade-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-upgrade-header.html:25:
debug("FAIL: Connected");
On 2015/01/13 05:31:52, tyoshino wrote:
> testFailed("Unexpectedly Connected.");

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-no-upgrade-header.html:41:
debug("PASS: onerror called");
On 2015/01/13 05:31:52, tyoshino wrote:
> testPassed("onerror() was called");

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null.html:49:
debug("onerror() was called");
On 2015/01/13 05:31:52, tyoshino wrote:
> testPassed

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/handshake-fail-by-wrong-accept-header.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/handshake-fail-by-wrong-accept-header.html:33:
testPassed("onerror called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> onerror() was called

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/interleaved-fragments.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/interleaved-fragments.html:38: debug("onerror()
was called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> Let's use testPassed, and remove ".".

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/invalid-continuation.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/invalid-continuation.html:38: debug("onerror
was called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> onerror() was called

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/invalid-encode-length.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/invalid-encode-length.html:49: debug("onerror()
was called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> Let's use testPassed, and remove ".".

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/invalid-masked-frames-from-server.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/invalid-masked-frames-from-server.html:38:
debug("onerror() was called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> Let's use testPassed, and remove ".".

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/long-control-frame.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/long-control-frame.html:33: debug("onerror()
was called");
On 2015/01/13 05:31:52, tyoshino wrote:
> Let's use testPassed

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/long-invalid-header.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/long-invalid-header.html:29: debug("Error
occured");
On 2015/01/13 05:31:52, tyoshino wrote:
> testPassed("onerror() was called");

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/permessage-deflate-invalid-parameter.html
(right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/permessage-deflate-invalid-parameter.html:51:
testPassed("onerror() was called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> Remove "." to align with shouldBeFalse()'s output

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/reserved-bits.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/reserved-bits.html:53: testPassed("onerror()
was called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> Remove "."

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/reserved-opcodes.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/reserved-opcodes.html:53: testPassed("onerror()
was called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> Remove "."

Done.

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
File LayoutTests/http/tests/websocket/too-long-payload.html (right):

https://codereview.chromium.org/817733004/diff/1/LayoutTests/http/tests/webso...
LayoutTests/http/tests/websocket/too-long-payload.html:38: testPassed("onerror()
was called.");
On 2015/01/13 05:31:52, tyoshino wrote:
> Remove "."

Done.

[tyoshino (SeeGerritForStatus), 2015-01-13 11:01:28]

lgtm

Thanks

[Paritosh Kumar, 2015-01-13 11:05:09]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2015-01-13 11:06:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/817733004/60001

[commit-bot: I haz the power, 2015-01-13 13:32:44]

Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188293