Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 817693002: Handle null argument for Selection.selectAllChildren() (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
fs
CC:
blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Handle null argument for Selection.selectAllChildren() Blink r186929 "Make some Selection function arguments non-optional" mistakenly assumed that this cannot be null, but without strict type checking it can be. Per spec anything other than Node should throw a TypeError, but begin by reverting to the old state. Add a test that would trigger this assert for which the pass condition can be inverted later. BUG=443721 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M LayoutTests/editing/selection/selectAllChildren.html View 3 chunks +13 lines, -18 lines 0 comments Download
M LayoutTests/editing/selection/selectAllChildren-expected.txt View 1 chunk +13 lines, -6 lines 0 comments Download
M Source/core/editing/DOMSelection.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
6 years ago (2014-12-19 12:38:50 UTC) #2
fs
lgtm
6 years ago (2014-12-19 12:47:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817693002/1
6 years ago (2014-12-19 13:04:26 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-19 13:39:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187530

Powered by Google App Engine
This is Rietveld 408576698