Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: cc/resources/scoped_gpu_raster_unittest.cc

Issue 817673004: cc: TextureUploader - Reset GL_UNPACK_ALIGNMENT to 4 before uploading images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unittest for ScopedGpuRaster state restore. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/scoped_gpu_raster_unittest.cc
diff --git a/cc/resources/scoped_gpu_raster_unittest.cc b/cc/resources/scoped_gpu_raster_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..90e5aa9e9641f28f1cfe98520b1c9d67aec634f3
--- /dev/null
+++ b/cc/resources/scoped_gpu_raster_unittest.cc
@@ -0,0 +1,38 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/resources/scoped_gpu_raster.h"
+#include "cc/test/test_context_provider.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace cc {
+namespace {
+
+class ScopedGpuRasterTest : public testing::Test {
+ public:
+ ScopedGpuRasterTest() {}
+};
+
+// Releasing ScopedGpuRaster should restore GL_UNPACK_ALIGNMENT == 4.
+TEST(ScopedGpuRasterTest, RestoresUnpackAlignment) {
+ scoped_refptr<TestContextProvider> provider = TestContextProvider::Create();
+ gpu::gles2::GLES2Interface* gl = provider->ContextGL();
+ GLint unpack_alignment = 0;
+ gl->GetIntegerv(GL_UNPACK_ALIGNMENT, &unpack_alignment);
+ EXPECT_EQ(4, unpack_alignment);
+
+ {
+ scoped_ptr<ScopedGpuRaster> scoped_gpu_raster(
+ new ScopedGpuRaster(provider.get()));
+ gl->PixelStorei(GL_UNPACK_ALIGNMENT, 1);
+ gl->GetIntegerv(GL_UNPACK_ALIGNMENT, &unpack_alignment);
+ EXPECT_EQ(1, unpack_alignment);
+ }
+
+ gl->GetIntegerv(GL_UNPACK_ALIGNMENT, &unpack_alignment);
+ EXPECT_EQ(4, unpack_alignment);
+}
+
+} // namespace
+} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698