Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: content/browser/devtools/shared_worker_devtools_agent_host.cc

Issue 817653002: Split EmbeddedWorkerDevToolsManager into two for Shared- and ServiceWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + indent fixes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/shared_worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/shared_worker_devtools_agent_host.cc b/content/browser/devtools/shared_worker_devtools_agent_host.cc
index 61133a55dbb1b852a71ddac97e71ce8e02c78cec..b823ea7af3e92f7dcc6b9b66d442ddc1a03462c7 100644
--- a/content/browser/devtools/shared_worker_devtools_agent_host.cc
+++ b/content/browser/devtools/shared_worker_devtools_agent_host.cc
@@ -5,16 +5,17 @@
#include "content/browser/devtools/shared_worker_devtools_agent_host.h"
#include "base/strings/utf_string_conversions.h"
+#include "content/browser/devtools/shared_worker_devtools_manager.h"
+#include "content/browser/shared_worker/shared_worker_instance.h"
#include "content/browser/shared_worker/shared_worker_service_impl.h"
#include "content/public/browser/browser_thread.h"
-#include "content/public/browser/render_process_host.h"
namespace content {
namespace {
void TerminateSharedWorkerOnIO(
- EmbeddedWorkerDevToolsAgentHost::WorkerId worker_id) {
+ WorkerDevToolsAgentHost::WorkerId worker_id) {
SharedWorkerServiceImpl::GetInstance()->TerminateWorker(
worker_id.first, worker_id.second);
}
@@ -24,7 +25,7 @@ void TerminateSharedWorkerOnIO(
SharedWorkerDevToolsAgentHost::SharedWorkerDevToolsAgentHost(
WorkerId worker_id,
const SharedWorkerInstance& shared_worker)
- : EmbeddedWorkerDevToolsAgentHost(worker_id),
+ : WorkerDevToolsAgentHost(worker_id),
shared_worker_(new SharedWorkerInstance(shared_worker)) {
}
@@ -56,6 +57,8 @@ bool SharedWorkerDevToolsAgentHost::Matches(
}
SharedWorkerDevToolsAgentHost::~SharedWorkerDevToolsAgentHost() {
+ SharedWorkerDevToolsManager::GetInstance()->RemoveInspectedWorkerData(
+ worker_id());
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698