Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: cc/scheduler/scheduler.h

Issue 817603002: cc: Make scheduling be driven by vsync for android webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not reset active_tree_needs_first_draw_ Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler.h
diff --git a/cc/scheduler/scheduler.h b/cc/scheduler/scheduler.h
index 3a4af5a1930227cde95a5f2347609e0b44df481d..4b039dee337cb15b52ef39a3b5f5286c3ba5edad 100644
--- a/cc/scheduler/scheduler.h
+++ b/cc/scheduler/scheduler.h
@@ -41,10 +41,12 @@ class SchedulerClient {
virtual void ScheduledActionActivateSyncTree() = 0;
virtual void ScheduledActionBeginOutputSurfaceCreation() = 0;
virtual void ScheduledActionPrepareTiles() = 0;
+ virtual void ScheduledActionInvalidateOutputSurface() = 0;
virtual void DidAnticipatedDrawTimeChange(base::TimeTicks time) = 0;
virtual base::TimeDelta DrawDurationEstimate() = 0;
virtual base::TimeDelta BeginMainFrameToCommitDurationEstimate() = 0;
virtual base::TimeDelta CommitToActivateDurationEstimate() = 0;
+ // TODO(sunnyps): Rename DidBeginImplFrameDeadline to DidFinishImplFrame.
virtual void DidBeginImplFrameDeadline() = 0;
virtual void SendBeginFramesToChildren(const BeginFrameArgs& args) = 0;
virtual void SendBeginMainFrameNotExpectedSoon() = 0;
@@ -95,6 +97,8 @@ class CC_EXPORT Scheduler : public BeginFrameObserverMixIn {
// BeginFrameObserverMixin
bool OnBeginFrameMixInDelegate(const BeginFrameArgs& args) override;
+ void OnDrawForOutputSurface();
+
const SchedulerSettings& settings() const { return settings_; }
void CommitVSyncParameters(base::TimeTicks timebase,
@@ -210,11 +214,9 @@ class CC_EXPORT Scheduler : public BeginFrameObserverMixIn {
base::Closure begin_retro_frame_closure_;
base::Closure begin_impl_frame_deadline_closure_;
- base::Closure poll_for_draw_triggers_closure_;
base::Closure advance_commit_state_closure_;
base::CancelableClosure begin_retro_frame_task_;
base::CancelableClosure begin_impl_frame_deadline_task_;
- base::CancelableClosure poll_for_draw_triggers_task_;
base::CancelableClosure advance_commit_state_task_;
SchedulerStateMachine state_machine_;
@@ -223,7 +225,7 @@ class CC_EXPORT Scheduler : public BeginFrameObserverMixIn {
private:
void ScheduleBeginImplFrameDeadline();
- void RescheduleBeginImplFrameDeadlineIfNeeded();
+ void ScheduleBeginImplFrameDeadlineIfNeeded();
void SetupNextBeginFrameIfNeeded();
void PostBeginRetroFrameIfNeeded();
void SetupPollingMechanisms();
@@ -233,9 +235,11 @@ class CC_EXPORT Scheduler : public BeginFrameObserverMixIn {
void AdvanceCommitStateIfPossible();
bool IsBeginMainFrameSentOrStarted() const;
void BeginRetroFrame();
+ void BeginImplFrameWithDeadline(const BeginFrameArgs& args);
+ void BeginImplFrameSynchronous(const BeginFrameArgs& args);
void BeginImplFrame(const BeginFrameArgs& args);
+ void FinishImplFrame();
void OnBeginImplFrameDeadline();
- void PollForAnticipatedDrawTriggers();
void PollToAdvanceCommitState();
void UpdateActiveFrameSource();

Powered by Google App Engine
This is Rietveld 408576698