Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: content/browser/android/in_process/synchronous_compositor_impl.h

Issue 817603002: cc: Make scheduling be driven by vsync for android webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix misc bugs introduced in last two patches Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/in_process/synchronous_compositor_impl.h
diff --git a/content/browser/android/in_process/synchronous_compositor_impl.h b/content/browser/android/in_process/synchronous_compositor_impl.h
index d6cacf0dee66e8e0865d2695d988d97dc4dbd4c6..7af738d5f8ac9952898b0aad70a62afd93434fd2 100644
--- a/content/browser/android/in_process/synchronous_compositor_impl.h
+++ b/content/browser/android/in_process/synchronous_compositor_impl.h
@@ -56,7 +56,12 @@ class SynchronousCompositorImpl
void DidDestroyRendererObjects();
// Called by SynchronousCompositorExternalBeginFrameSource.
- void NeedsBeginFramesChanged() const;
+ void OnNeedsBeginFramesChange(bool needs_begin_frames);
+
+ // Called by SynchronousCompositorOutputSurface.
+ void PostInvalidate();
+ void SendBeginFrameOnDraw();
+ void DidActivatePendingTree();
// SynchronousCompositor
bool InitializeHwDraw() override;
@@ -72,6 +77,8 @@ class SynchronousCompositorImpl
void ReturnResources(const cc::CompositorFrameAck& frame_ack) override;
void SetMemoryPolicy(size_t bytes_limit) override;
void DidChangeRootLayerScrollOffset() override;
+ void SetIsActive(bool is_active) override;
+ void SendBeginFrame(cc::BeginFrameArgs args) override;
// LayerScrollOffsetDelegate
gfx::ScrollOffset GetTotalScrollOffset() override;
@@ -96,9 +103,9 @@ class SynchronousCompositorImpl
void SetClient(SynchronousCompositorClient* compositor_client);
void UpdateFrameMetaData(const cc::CompositorFrameMetadata& frame_info);
void NotifyDidDestroyCompositorToClient();
- void DidActivatePendingTree();
void DeliverMessages();
bool CalledOnValidThread() const;
+ void UpdateNeedsBeginFrames();
SynchronousCompositorClient* compositor_client_;
SynchronousCompositorOutputSurface* output_surface_;
@@ -107,6 +114,8 @@ class SynchronousCompositorImpl
const int routing_id_;
cc::InputHandler* input_handler_;
bool invoking_composite_;
+ bool is_active_;
+ bool renderer_needs_begin_frames_;
base::WeakPtrFactory<SynchronousCompositorImpl> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698