Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: runtime/vm/assembler_mips.cc

Issue 817593002: Improve generated MIPS code for conditional expressions and branches by delaying (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_mips.h ('k') | runtime/vm/constants_mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips.cc
===================================================================
--- runtime/vm/assembler_mips.cc (revision 42554)
+++ runtime/vm/assembler_mips.cc (working copy)
@@ -15,7 +15,7 @@
namespace dart {
#if defined(USING_SIMULATOR)
-DECLARE_FLAG(bool, trace_sim);
+DECLARE_FLAG(int, trace_sim_after);
#endif
DEFINE_FLAG(bool, print_stop_message, false, "Print stop message.");
DECLARE_FLAG(bool, inline_alloc);
@@ -503,18 +503,6 @@
}
-void Assembler::CompareObject(Register rd1, Register rd2,
- Register rn, const Object& object) {
- ASSERT(!in_delay_slot_);
- ASSERT(rn != TMP);
- ASSERT(rd1 != TMP);
- ASSERT(rd1 != rd2);
- LoadObject(TMP, object);
- slt(rd1, rn, TMP);
- slt(rd2, TMP, rn);
-}
-
-
// Preserves object and value registers.
void Assembler::StoreIntoObjectFilterNoSmi(Register object,
Register value,
@@ -1265,7 +1253,7 @@
// Don't bother adding in the messages unless tracing is enabled, and we are
// running in the simulator.
#if defined(USING_SIMULATOR)
- if (FLAG_trace_sim) {
+ if (FLAG_trace_sim_after != -1) {
Label msg;
b(&msg);
Emit(reinterpret_cast<int32_t>(message));
« no previous file with comments | « runtime/vm/assembler_mips.h ('k') | runtime/vm/constants_mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698