runtime/vm/disassembler_arm64.cc - Issue 817583003: Process two 32-bit digits as one 64-bit digit in all bigint intrinsics on ARM64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler_arm64.cc

Issue 817583003: Process two 32-bit digits as one 64-bit digit in all bigint intrinsics on ARM64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/disassembler_arm64.cc

===================================================================

--- runtime/vm/disassembler_arm64.cc (revision 42584)

+++ runtime/vm/disassembler_arm64.cc (working copy)

@@ -1061,7 +1061,7 @@

if ((instr->Bits(29, 2) == 0) && (instr->Bits(21, 3) == 0) &&

(instr->Bit(15) == 0)) {

if (instr->RaField() == R31) {

- Format(instr, "mul'sf, 'rd, 'rn, 'rm");

+ Format(instr, "mul'sf 'rd, 'rn, 'rm");

} else {

Format(instr, "madd'sf 'rd, 'rn, 'rm, 'ra");

}

@@ -1071,6 +1071,9 @@

} else if ((instr->Bits(29, 2) == 0) && (instr->Bits(21, 3) == 2) &&

(instr->Bit(15) == 0)) {

Format(instr, "smulh 'rd, 'rn, 'rm");

+ } else if ((instr->Bits(29, 2) == 0) && (instr->Bits(21, 3) == 6) &&

+ (instr->Bit(15) == 0)) {

+ Format(instr, "umulh 'rd, 'rn, 'rm");

} else if ((instr->Bits(29, 3) == 4) && (instr->Bits(21, 3) == 5) &&

(instr->Bit(15) == 0)) {

Format(instr, "umaddl 'rd, 'rn, 'rm, 'ra");

« no previous file with comments | « runtime/vm/constants_arm64.h ('k') | runtime/vm/intrinsifier_arm64.cc » ('j') | runtime/vm/intrinsifier_arm64.cc » ('J')