Issue 817483005: LCodeGen::CallKnownFunction gets the function in register.

Issue 817483005: LCodeGen::CallKnownFunction gets the function in register. (Closed)

Created:
5 years, 11 months ago by ulan

Modified:
5 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

LCodeGen::CallKnownFunction gets the function in register. There is no need to embed function pointer in code. BUG=v8:3823 LOG=N Committed: https://crrev.com/def7c53869f86a525eb539e0c0254fdc4e512b9b Cr-Commit-Position: refs/heads/master@{#26152}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -161 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	4 chunks	+8 lines, -14 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.h	View		1 chunk	+4 lines, -8 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View		2 chunks	+4 lines, -14 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View		1 chunk	+3 lines, -10 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		4 chunks	+8 lines, -14 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		4 chunks	+7 lines, -14 lines	0 comments	Download
M	src/mips64/lithium-codegen-mips64.h	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/mips64/lithium-codegen-mips64.cc	View		4 chunks	+7 lines, -14 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		4 chunks	+7 lines, -14 lines	0 comments	Download
M	src/x87/lithium-codegen-x87.h	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	src/x87/lithium-codegen-x87.cc	View		4 chunks	+8 lines, -14 lines	0 comments	Download

Total messages: 7 (2 generated)

ulan

Hi Jakob, Please take a look. This removes dead code and calls the register version ...

5 years, 11 months ago (2015-01-19 16:21:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817483005/20001

5 years, 11 months ago (2015-01-20 10:52:07 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-20 11:38:57 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/def7c53869f86a525eb539e0c0254fdc4e512b9b
Cr-Commit-Position: refs/heads/master@{#26152}