Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 817483004: Fix computation of bound in FillBounds::updateSaveBounds (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix computation of bound in FillBounds::updateSaveBounds intersect doesn't change the bounds when the two bounds do not intersect. This is definitely not the intended behavior. With the SKPs captured on 12/23/14, Chrome began passing Skia drawPicture ops that did not intersect the current clip - which revealed this bug. Committed: https://skia.googlesource.com/skia/+/c187a3c8849ba5e409f79ead21cd5bc82173d9f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
robertphillips
5 years, 11 months ago (2014-12-30 21:37:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817483004/1
5 years, 11 months ago (2014-12-30 21:45:05 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2014-12-30 21:45:05 UTC) #5
bsalomon
lgtm
5 years, 11 months ago (2014-12-30 21:51:21 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2014-12-30 21:53:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c187a3c8849ba5e409f79ead21cd5bc82173d9f8

Powered by Google App Engine
This is Rietveld 408576698