Issue 817283005: use conics for ovals and roundrects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 817283005: use conics for ovals and roundrects (Closed)

Created:
5 years, 11 months ago by reed2

Modified:
5 years, 11 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

use conics for ovals and roundrects adapted from https://codereview.chromium.org/831313002/ BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/2bf1c4d58b84c73c6421edcb25e3afb4971da200

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -7 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+84 lines, -0 lines	0 comments	Download
M	gyp/skia_for_android_framework_defines.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkPath.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/pathops/SkOpEdgeBuilder.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817283005/1

5 years, 11 months ago (2015-01-06 04:05:52 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2bf1c4d58b84c73c6421edcb25e3afb4971da200

5 years, 11 months ago (2015-01-06 04:15:31 UTC) #3

reed1

5 years, 11 months ago (2015-01-06 15:12:43 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/840573002/ by reed@google.com.

The reason for reverting is: need fix in edgebuilder+aa.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages