Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 817273003: [Mac] Make ConstrainedWebDialog resize with parent window (Closed)

Created:
6 years ago by Jiang Jiang
Modified:
6 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, apacible, awong
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ConstrainedWebDialog resize with parent window BUG=415526 Committed: https://crrev.com/6b29eeed84720fc77b5ec2b5c9abe94a34df26fe Cr-Commit-Position: refs/heads/master@{#309452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.h View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jiang Jiang
6 years ago (2014-12-22 16:45:16 UTC) #2
Avi (use Gerrit)
On 2014/12/22 16:45:16, Jiang Jiang wrote: LGTM
6 years ago (2014-12-22 18:16:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817273003/1
6 years ago (2014-12-22 19:13:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 20:23:27 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-22 20:24:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b29eeed84720fc77b5ec2b5c9abe94a34df26fe
Cr-Commit-Position: refs/heads/master@{#309452}

Powered by Google App Engine
This is Rietveld 408576698