Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 817243003: [turbofan] Introduce CommonOperatorReducer. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce CommonOperatorReducer. The CommonOperatorReducer currently takes care of redundant Phis, EffectPhis and Selects. This functionality overlaps with ControlReducer, but is required to make certain optimizations effective, since the ControlReducer only runs really early and really late in the pipeline and therefore other reducers aren't reapplied properly after redundant phi/select elimination. TEST=unittests R=hpayer@chromium.org Committed: https://crrev.com/ee98a1d76023e782750eaf9057b1520f0e6fb9d3 Cr-Commit-Position: refs/heads/master@{#25922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -9 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/compiler/common-operator-reducer.h View 2 chunks +7 lines, -9 lines 0 comments Download
A src/compiler/common-operator-reducer.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 4 chunks +7 lines, -0 lines 0 comments Download
A test/unittests/compiler/common-operator-reducer-unittest.cc View 1 chunk +110 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years ago (2014-12-22 11:23:51 UTC) #1
Hannes Payer (out of office)
lgtm
6 years ago (2014-12-22 13:03:38 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee98a1d76023e782750eaf9057b1520f0e6fb9d3 Cr-Commit-Position: refs/heads/master@{#25922}
6 years ago (2014-12-22 13:06:50 UTC) #3
Benedikt Meurer
6 years ago (2014-12-22 13:06:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee98a1d76023e782750eaf9057b1520f0e6fb9d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698