Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 817233002: Add window.IN_TEST in gallery/js/background.js. (Closed)

Created:
6 years ago by yawano
Modified:
6 years ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add window.IN_TEST in gallery/js/background.js. window.IN_TEST is not defined in gallery app. It caused a warning of closure compiler, and IN_TEST flag should be set true also in tests of gallery app. BUG=433728 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default out/Release/browser_tests --gtest_filter=*GalleryBrowserTest* Committed: https://crrev.com/9965b3de0a9760e3fe23e7a8ad3888229ff29b67 Cr-Commit-Position: refs/heads/master@{#309402}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ui/file_manager/externs/gallery_foreground.js View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/background.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
6 years ago (2014-12-22 05:47:07 UTC) #2
mtomasz
lgtm
6 years ago (2014-12-22 05:57:54 UTC) #3
yawano
On 2014/12/22 05:57:54, mtomasz wrote: > lgtm Thank you!
6 years ago (2014-12-22 05:58:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817233002/1
6 years ago (2014-12-22 05:58:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 06:48:30 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 06:50:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9965b3de0a9760e3fe23e7a8ad3888229ff29b67
Cr-Commit-Position: refs/heads/master@{#309402}

Powered by Google App Engine
This is Rietveld 408576698