Issue 817223003: Remove custom weak handling of monomorphic IC.

Issue 817223003: Remove custom weak handling of monomorphic IC. (Closed)

Created:
6 years ago by ulan

Modified:
6 years ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Remove custom weak handling of monomorphic IC. This is not needed anymore since all ICs use weak cells to embed maps. BUG=v8:3629 LOG=N Committed: https://crrev.com/0344722a160703e3e88568bb063b41eefa33e8c4 Cr-Commit-Position: refs/heads/master@{#25928}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -228 lines)			Patch
M	src/code-stubs.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/heap/mark-compact.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap/mark-compact.cc	View	3 chunks	+12 lines, -51 lines	0 comments	Download
M	src/heap/objects-visiting-inl.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/ic/ic.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/ic/ic.cc	View	1 chunk	+0 lines, -36 lines	0 comments	Download
M	src/ic/ic-compiler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ic/ic-inl.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/objects.h	View	8 chunks	+5 lines, -31 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+0 lines, -49 lines	0 comments	Download
M	src/objects-debug.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+0 lines, -35 lines	0 comments	Download

Total messages: 8 (2 generated)

ulan

On 2014/12/22 09:58:46, ulan wrote: > PTAL Custom weak handling was introduced in CL 188783003

6 years ago (2014-12-22 10:00:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817223003/1

6 years ago (2014-12-22 14:35:33 UTC) #6

commit-bot: I haz the power

6 years ago (2014-12-22 15:04:30 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0344722a160703e3e88568bb063b41eefa33e8c4
Cr-Commit-Position: refs/heads/master@{#25928}