Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 817153002: Switch users of foundation_util.h to include it directly and clean up uses of mac_util.h. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, asanka, sadrul, chromoting-reviews_chromium.org, hguihot+watch_chromium.org, mikhal+watch_chromium.org, rsesek+watch_chromium.org, noyau+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, hubbe+watch_chromium.org, mlamouri+watch-content_chromium.org, jennb, imcheng+watch_chromium.org, jasonroberts+watch_google.com, jianli, feature-media-reviews_chromium.org, dcheng, kalyank, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, tfarina, avayvod+watch_chromium.org, Dmitry Titov, pwestin+watch_google.com, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch users of foundation_util.h to include it directly and clean up uses of mac_util.h. BUG=none TEST=none TBR=ben@chromium.org NOTRY=TRUE Committed: https://crrev.com/69fed022b5f6097f9fa2424f289b93023613bf8d Cr-Commit-Position: refs/heads/master@{#309368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -115 lines) Patch
M base/mac/authorization_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/launch_services_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/mac/mac_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_service.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/cast_streaming/performance_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/mac/dock.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/install_from_dmg.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/keystone_glue.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service_process/service_process_control_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/menu_tracked_button.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_state_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_paths_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/mac/cfbundle_blocker.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/mac/launchd.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/remoting/webapp_javascript_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/safari_importer.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/app/breakpad_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/file_metadata_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/mac/font_loader.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/infobars/infobar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/mac/audio_device_listener_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M skia/ext/skia_utils_mac_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accelerated_widget_mac/io_surface_layer.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accelerated_widget_mac/io_surface_texture.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/cocoa/app_list_pager_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/cocoa/nsview_additions.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/color_profile_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/image/image.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
Avi (use Gerrit)
6 years ago (2014-12-21 00:40:52 UTC) #2
Avi (use Gerrit)
On 2014/12/21 00:40:52, Avi wrote: Rohit: FYI
6 years ago (2014-12-21 00:49:22 UTC) #3
rohitrao (ping after 24h)
LGTM Most of these callers didn't need either mac_util or foundation_util? Did you have to ...
6 years ago (2014-12-21 00:50:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817153002/1
6 years ago (2014-12-21 00:51:00 UTC) #6
Avi (use Gerrit)
On 2014/12/21 00:50:01, rohitrao wrote: > LGTM > > Most of these callers didn't need ...
6 years ago (2014-12-21 00:57:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/31859)
6 years ago (2014-12-21 00:57:40 UTC) #9
Avi (use Gerrit)
On 2014/12/21 00:57:40, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-21 01:01:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817153002/1
6 years ago (2014-12-21 01:02:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-21 01:03:23 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-21 01:04:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69fed022b5f6097f9fa2424f289b93023613bf8d
Cr-Commit-Position: refs/heads/master@{#309368}

Powered by Google App Engine
This is Rietveld 408576698