Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 817143006: Fix incorrect comparison with bitmask. (Closed)

Created:
5 years, 11 months ago by DaleCurtis
Modified:
5 years, 11 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect comparison with bitmask. This may have caused the audio power save blocker to not be created or released appropriately when tabs move in and out of the background. BUG=367785 TEST=tab audio indicator works as expected. Committed: https://crrev.com/2701185b84d9e8ef62068839620599b891fc1e1e Cr-Commit-Position: refs/heads/master@{#310118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
5 years, 11 months ago (2015-01-06 02:02:06 UTC) #2
nasko
LGTM
5 years, 11 months ago (2015-01-06 18:15:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817143006/1
5 years, 11 months ago (2015-01-06 18:35:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 19:53:02 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 19:53:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2701185b84d9e8ef62068839620599b891fc1e1e
Cr-Commit-Position: refs/heads/master@{#310118}

Powered by Google App Engine
This is Rietveld 408576698