test/cctest/test-strings.cc - Issue 817143002: Contribution of PowerPC port (continuation of 422063005)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-strings.cc

Issue 817143002: Contribution of PowerPC port (continuation of 422063005) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Contribution of PowerPC port - rebase and address initial set of comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-strings.cc

diff --git a/test/cctest/test-strings.cc b/test/cctest/test-strings.cc

index d1f23f75a6bf6b0a3f9de562015a6bef81463b73..c77fc36a05d181a3b219bcd27663effc1b6f3092 100644

--- a/test/cctest/test-strings.cc

+++ b/test/cctest/test-strings.cc

@@ -1445,6 +1445,7 @@ TEST(InvalidExternalString) {

static const int invalid = String::kMaxLength + 1; \

HandleScope scope(isolate); \

Vector<TYPE> dummy = Vector<TYPE>::New(invalid); \

+ memset(dummy.start(), 0x0, dummy.length() * sizeof(TYPE)); \

CHECK(isolate->factory()->FUN(Vector<const TYPE>::cast(dummy)).is_null()); \

memset(dummy.start(), 0x20, dummy.length() * sizeof(TYPE)); \

CHECK(isolate->has_pending_exception()); \

« no previous file with comments | « test/cctest/test-regexp.cc ('k') | test/mjsunit/big-array-literal.js » ('j') | no next file with comments »