Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 817123003: Remove commandline flag --disable-javascript (Closed)

Created:
5 years, 11 months ago by MRV
Modified:
5 years, 11 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove commandline flag --disable-javascript BUG=366348 Committed: https://crrev.com/6c5c38467301a9d56a12829452b1e823dce37728 Cr-Commit-Position: refs/heads/master@{#310959}

Patch Set 1 #

Patch Set 2 : Removed unsed variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
MRV
thakis@chromium.org: Please review changes in chrome avi@chromium.org: Please review changes in content PTAL
5 years, 11 months ago (2015-01-09 10:13:48 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 11 months ago (2015-01-09 14:56:41 UTC) #3
Nico
lgtm
5 years, 11 months ago (2015-01-10 01:00:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817123003/20001
5 years, 11 months ago (2015-01-10 03:14:39 UTC) #6
MRV
On 2015/01/10 01:00:14, Nico wrote: > lgtm Thanks mr.avi and mr.nico for your time and ...
5 years, 11 months ago (2015-01-10 03:17:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-10 04:14:43 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 04:15:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c5c38467301a9d56a12829452b1e823dce37728
Cr-Commit-Position: refs/heads/master@{#310959}

Powered by Google App Engine
This is Rietveld 408576698