content/renderer/render_view_impl.cc - Issue 817103002: Only take basename of default_file_name when starting a File Chooser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 817103002: Only take basename of default_file_name when starting a File Chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: POSIX fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 8285c45075692350cc627ff5723d2ef43427207e..3829a19d8ee387bcb36294bd7a113d0b6ed8a2ff 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1757,7 +1757,7 @@ bool RenderViewImpl::runFileChooser(

ipc_params.mode = FileChooserParams::Open;

ipc_params.title = params.title;

ipc_params.default_file_name =

- base::FilePath::FromUTF16Unsafe(params.initialValue);

+ base::FilePath::FromUTF16Unsafe(params.initialValue).BaseName();

ipc_params.accept_types.reserve(params.acceptTypes.size());

for (size_t i = 0; i < params.acceptTypes.size(); ++i)

ipc_params.accept_types.push_back(params.acceptTypes[i]);

« content/browser/security_exploit_browsertest.cc ('K') | « content/browser/security_exploit_browsertest.cc ('k') | no next file » | no next file with comments »