chrome/browser/chromeos/drive/file_system_util_unittest.cc - Issue 817063006: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/drive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system_util_unittest.cc

Issue 817063006: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/drive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/drive/drive_integration_service_unittest.cc ('K') | « chrome/browser/chromeos/drive/file_system_unittest.cc ('k') | chrome/browser/chromeos/drive/file_task_executor.cc » ('j') | chrome/browser/chromeos/drive/file_write_watcher_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system_util_unittest.cc

diff --git a/chrome/browser/chromeos/drive/file_system_util_unittest.cc b/chrome/browser/chromeos/drive/file_system_util_unittest.cc

index ab83337024f87317b026efe91bf0205a4a6f98de..500ac524c5fd9f756602bed1b48f31baf6813372 100644

--- a/chrome/browser/chromeos/drive/file_system_util_unittest.cc

+++ b/chrome/browser/chromeos/drive/file_system_util_unittest.cc

@@ -39,9 +39,7 @@ class ProfileRelatedFileSystemUtilTest : public testing::Test {

: testing_profile_manager_(TestingBrowserProcess::GetGlobal()) {

}

- virtual void SetUp() override {

- ASSERT_TRUE(testing_profile_manager_.SetUp());

- }

+ void SetUp() override { ASSERT_TRUE(testing_profile_manager_.SetUp()); }

hashimoto 2015/01/21 04:50:12 nit: I think ASSERT_TRUE should be better placed i

TestingProfileManager& testing_profile_manager() {

return testing_profile_manager_;