Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1885)

Unified Diff: chrome/browser/chromeos/drive/change_list_loader_unittest.cc

Issue 817063006: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/drive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/change_list_loader_unittest.cc
diff --git a/chrome/browser/chromeos/drive/change_list_loader_unittest.cc b/chrome/browser/chromeos/drive/change_list_loader_unittest.cc
index dc9949373e8830be11d03bd69273d3eb1ad3dbf1..f16848b6473997f55da9de6467362db636b6bd55 100644
--- a/chrome/browser/chromeos/drive/change_list_loader_unittest.cc
+++ b/chrome/browser/chromeos/drive/change_list_loader_unittest.cc
@@ -36,9 +36,7 @@ class TestChangeListLoaderObserver : public ChangeListLoaderObserver {
loader_->AddObserver(this);
}
- virtual ~TestChangeListLoaderObserver() {
- loader_->RemoveObserver(this);
- }
+ ~TestChangeListLoaderObserver() override { loader_->RemoveObserver(this); }
hashimoto 2015/01/21 04:50:12 nit: I think RemoveObserver should be better place
const FileChange& changed_files() const { return changed_files_; }
void clear_changed_files() { changed_files_.ClearForTest(); }
@@ -51,15 +49,13 @@ class TestChangeListLoaderObserver : public ChangeListLoaderObserver {
}
// ChageListObserver overrides:
- virtual void OnFileChanged(const FileChange& changed_files) override {
+ void OnFileChanged(const FileChange& changed_files) override {
changed_files_.Apply(changed_files);
}
- virtual void OnLoadFromServerComplete() override {
+ void OnLoadFromServerComplete() override {
++load_from_server_complete_count_;
}
- virtual void OnInitialLoadComplete() override {
- ++initial_load_complete_count_;
- }
+ void OnInitialLoadComplete() override { ++initial_load_complete_count_; }
hashimoto 2015/01/21 04:50:12 ditto.
private:
ChangeListLoader* loader_;
@@ -72,7 +68,7 @@ class TestChangeListLoaderObserver : public ChangeListLoaderObserver {
class ChangeListLoaderTest : public testing::Test {
protected:
- virtual void SetUp() override {
+ void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
pref_service_.reset(new TestingPrefServiceSimple);
test_util::RegisterDrivePrefs(pref_service_->registry());

Powered by Google App Engine
This is Rietveld 408576698