Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 817053002: Add shadowRootReady callback for SkyElement. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
rafaelw, eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add shadowRootReady callback for SkyElement. This is called right after stamping the template into the ShadowRoot. This is a useful place to querySelector/getElementById for elements inside the ShadowRoot. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ae54708999b008c42089e90fd821f872d3a4a24d

Patch Set 1 #

Patch Set 2 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M sky/framework/sky-element/sky-element.sky View 1 2 chunks +5 lines, -0 lines 0 comments Download
M sky/tests/framework/templates.sky View 1 1 chunk +9 lines, -0 lines 0 comments Download
M sky/tests/framework/templates-expected.txt View 1 1 chunk +4 lines, -3 lines 0 comments Download
M sky/tests/resources/test-element.sky View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
esprehn
6 years ago (2014-12-19 21:55:34 UTC) #2
eseidel
lgtm. WE could probably have a better name. "createdTemplate" feels to me like a "Template" ...
6 years ago (2014-12-19 21:58:39 UTC) #3
esprehn
On 2014/12/19 at 21:58:39, eseidel wrote: > lgtm. WE could probably have a better name. ...
6 years ago (2014-12-19 22:01:39 UTC) #4
esprehn
Committed patchset #2 (id:20001) manually as ae54708999b008c42089e90fd821f872d3a4a24d (presubmit successful).
6 years ago (2014-12-19 22:01:54 UTC) #5
rafaelw
6 years ago (2014-12-19 23:18:40 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698