Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 817033002: Allow the alpha folding optimization if the single draw's paint has a shader (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
reed1
CC:
reviews_skia.org, Kimmo Kinnunen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow the alpha folding optimization if the single draw's paint has a shader Let's land this and then leave for 2 weeks. BUG=skia:3119 Committed: https://skia.googlesource.com/skia/+/ca32da7533ed86fbbe50e078c751b0f1c198bb5b

Patch Set 1 #

Patch Set 2 : fearless #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/core/SkRecordOpts.cpp View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
6 years ago (2014-12-19 20:58:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817033002/20001
6 years ago (2014-12-19 21:44:38 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-19 21:44:39 UTC) #5
reed1
lgtm
6 years ago (2014-12-19 21:49:53 UTC) #6
robertphillips
Local testing on Linux didn't show any layout test changes
6 years ago (2014-12-21 18:50:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817033002/20001
6 years ago (2014-12-21 18:51:53 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-21 18:52:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ca32da7533ed86fbbe50e078c751b0f1c198bb5b

Powered by Google App Engine
This is Rietveld 408576698