Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 817023003: replace COMPILE_ASSERT with static_assert in gpu/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in gpu/ BUG=442514 Committed: https://crrev.com/7f032091dad424a76cb267772c27b9b165ed157f Cr-Commit-Position: refs/heads/master@{#309311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2556 lines, -2387 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +11 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.h View 3 chunks +6 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/share_group.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/cmd_buffer_common.h View 15 chunks +90 lines, -76 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format.h View 4 chunks +41 lines, -37 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 247 chunks +2371 lines, -2231 lines 0 comments Download
M gpu/command_buffer/service/common_decoder_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_clear_framebuffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/config/gpu_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Mostyn Bramley-Moore
@sievers: PTAL.
6 years ago (2014-12-19 22:46:25 UTC) #2
no sievers
lgtm The strings don't seem to add any value though, since they are just restating ...
6 years ago (2014-12-19 23:28:25 UTC) #3
no sievers
On 2014/12/19 23:28:25, sievers wrote: > lgtm > > The strings don't seem to add ...
6 years ago (2014-12-19 23:29:09 UTC) #4
Mostyn Bramley-Moore
On 2014/12/19 23:28:25, sievers wrote: > lgtm > > The strings don't seem to add ...
6 years ago (2014-12-19 23:38:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817023003/1
6 years ago (2014-12-19 23:39:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-20 00:37:11 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-20 00:38:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f032091dad424a76cb267772c27b9b165ed157f
Cr-Commit-Position: refs/heads/master@{#309311}

Powered by Google App Engine
This is Rietveld 408576698