cros: Remove system-level policy for audio capture allowed

cros: Remove system-level policy for audio capture allowed

The "audio capture allowed" policy exists both at the system level (local state) and at the user level (profile). This was done for historical reasons that no longer apply.

The user level policy still prevents audio capture via hooks in Chrome's media pipeline.

This CL simplifies the chromeos/audio and app_shell code that uses it.

BUG=443695
TEST=chromeos_unittests and app_shell_unittests

Committed: https://crrev.com/928c5e821a9885f255a337fad298c7f7d26b8511
Cr-Commit-Position: refs/heads/master@{#310360}

[James Cook, 2014-12-19 22:35:07]

jamescook@chromium.org changed reviewers:
+ jennyz@chromium.org

[James Cook, 2014-12-19 22:35:08]

jennyz, PTAL at audio

[jennyz, 2014-12-19 22:43:11]

lgtm

[James Cook, 2014-12-19 22:58:35]

jamescook@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[James Cook, 2014-12-19 22:58:36]

pastarmovj, PTAL

[James Cook, 2014-12-19 22:59:45]

jamescook@chromium.org changed reviewers:
+ derat@chromium.org

[James Cook, 2014-12-19 22:59:46]

derat, can I get OWNERS for c/b/chromeos?

[Daniel Erat, 2014-12-19 23:05:18]

lgtm (feel free to tbr stuff like that)

[James Cook, 2014-12-19 23:09:44]

pastarmovj, just FYI I will be out for the next two weeks, so don't expect a
rapid response to comments. :-)

See you all in the new year!

[pastarmovj, 2015-01-05 14:53:54]

Only one comment. LGTM otherwise.

https://codereview.chromium.org/817013002/diff/40001/chrome/test/data/policy/...
File chrome/test/data/policy/policy_test_cases.json (left):

https://codereview.chromium.org/817013002/diff/40001/chrome/test/data/policy/...
chrome/test/data/policy/policy_test_cases.json:1832: "local_state": true }
IIRC you should leave this in here for the user pref backed policy. Only remove
this line that states that the policy is backed by local_state.

[James Cook, 2015-01-05 19:08:13]

jamescook@chromium.org changed reviewers:
+ mnissler@chromium.org

[James Cook, 2015-01-05 19:08:14]

pastarmovj, can you take another look at the policy test case file?

mnissler, can I get OWNERS for a function-signature change in
c/b/prefs/browser_prefs.cc?

https://codereview.chromium.org/817013002/diff/40001/chrome/test/data/policy/...
File chrome/test/data/policy/policy_test_cases.json (left):

https://codereview.chromium.org/817013002/diff/40001/chrome/test/data/policy/...
chrome/test/data/policy/policy_test_cases.json:1832: "local_state": true }
On 2015/01/05 14:53:53, pastarmovj wrote:
> IIRC you should leave this in here for the user pref backed policy. Only
remove
> this line that states that the policy is backed by local_state.

Done, but I'm not sure this is necessary. Is the AudioCaptureAllowed user pref
policy testing handled by the data at line 1102?  Or does it mean something
special that this block sets AudioCaptureAllowed to true vs. 1102 setting it
false?  (False seems like the value you want policy to enforce.)

[Mattias Nissler (ping if slow), 2015-01-06 09:14:55]

browser_prefs.cc LGTM

[James Cook, 2015-01-06 17:39:09]

Ping pastarmovj?

[pastarmovj, 2015-01-07 10:03:56]

Sorry for the delay James. Tuesday was a public holiday in Bavaria. :)

I didn't notice that there is another one because I only checked the vicinity of
this one not so far up in the file. You don't have to keep both there in this
case. Sorry for inducing the extra work on you.

LGTM!

[James Cook, 2015-01-07 19:13:58]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2015-01-07 19:15:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/817013002/100001

[commit-bot: I haz the power, 2015-01-07 20:47:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-01-07 20:49:38]

Patchset 6 (id:??) landed as
https://crrev.com/928c5e821a9885f255a337fad298c7f7d26b8511
Cr-Commit-Position: refs/heads/master@{#310360}