Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 816973003: Fix WeakPtrFactory members in chromeos/ (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)
Modified:
5 years, 11 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory members in chromeos/ This forces WeakPtrs to be invalidated before other members' destructors run. See the bug or the documentation of WeakPtrFactory for more information. I'm in the process of trying to turn on a clang check for this (see the bug). BUG=303818 R=derat@chromium.org TBR=stevenjb@chromium.org Committed: https://crrev.com/4b73fadb148e51fdc0abff8ccc42bf33a0dc4efd Cr-Commit-Position: refs/heads/master@{#311383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chromeos/network/dhcp_proxy_script_fetcher_chromeos.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/network/network_sms_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dmichael (off chromium)
5 years, 11 months ago (2015-01-13 23:30:02 UTC) #1
Daniel Erat
lgtm
5 years, 11 months ago (2015-01-13 23:30:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816973003/1
5 years, 11 months ago (2015-01-13 23:36:19 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/35739)
5 years, 11 months ago (2015-01-13 23:42:20 UTC) #6
dmichael (off chromium)
I didn't see that chromeos/network has set noparent (I thought we didn't do that anymore?) ...
5 years, 11 months ago (2015-01-13 23:47:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816973003/1
5 years, 11 months ago (2015-01-13 23:48:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 01:19:26 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 01:20:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b73fadb148e51fdc0abff8ccc42bf33a0dc4efd
Cr-Commit-Position: refs/heads/master@{#311383}

Powered by Google App Engine
This is Rietveld 408576698