Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 81693003: Release media player resources when device is locked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed a mistake I just realized Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/android/media_player_bridge.h » ('j') | media/base/android/media_player_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index d37366ce7ee3d0978acc2b3d6569bae435f19b07..a83138aac5371524766c4ea759d40901e5e22a2b 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -164,8 +164,7 @@ void BrowserMediaPlayerManager::ExitFullscreen(bool release_media_player) {
return;
if (release_media_player)
player->Release();
- else
- player->SetVideoSurface(gfx::ScopedJavaSurface());
+ player->SetVideoSurface(gfx::ScopedJavaSurface());
}
void BrowserMediaPlayerManager::OnTimeUpdate(int player_id,
@@ -499,10 +498,7 @@ void BrowserMediaPlayerManager::OnSetVolume(int player_id, double volume) {
void BrowserMediaPlayerManager::OnReleaseResources(int player_id) {
MediaPlayerAndroid* player = GetPlayer(player_id);
- // Don't release the fullscreen player when tab visibility changes,
- // it will be released when user hit the back/home button or when
- // OnDestroyPlayer is called.
- if (player && player_id != fullscreen_player_id_)
+ if (player)
player->Release();
#if defined(GOOGLE_TV)
« no previous file with comments | « no previous file | media/base/android/media_player_bridge.h » ('j') | media/base/android/media_player_bridge.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698