Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 816923002: Switch FontFaceSet#ready from a method to an attribute (Closed)

Created:
6 years ago by Kunihiko Sakamoto
Modified:
5 years, 11 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -51 lines) Patch
M LayoutTests/fast/css/font-face-unicode-range-overlap-load.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/font-face-unicode-range-overlap-load-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontface-arraybuffer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontface-arraybuffer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-add-remove-while-loading.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-add-remove-while-loading-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-download-error.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-download-error-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-events.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-events-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-in-detached-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-in-detached-frame-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-loadingdone.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/fontfaceset-loadingdone-expected.txt View 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/fast/css/fontfaceset-multiple-faces.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-multiple-faces-download-error.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-multiple-faces-download-error-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-multiple-faces-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-multiple-families.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-multiple-families-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-unattached-document.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/fontfaceset-unattached-document-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/css/css-resources-referrer.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/css/css-resources-referrer-srcdoc.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/css/resource-timing-details-for-revalidation.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/css/resource-timing-details-for-revalidation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-css-resources-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-css-resources.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/webfont/fontface-style-change.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/webfont/fontfaceset-status-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/webfont/fontfaceset-status-attribute-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/webfont/webfont-cors.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/webfont/webfont-performance-duration.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/webfont/webfont-performance-duration-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/svg/custom/repaint-shadow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-zoom-coords-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/svg/zoom/page/zoom-zoom-coords-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/win/svg/zoom/page/zoom-zoom-coords-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/custom/repaint-shadow.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/repaint-shadow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/svg/zoom/page/zoom-zoom-coords.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/zoom/page/zoom-zoom-coords-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/FontFaceSet.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
6 years ago (2014-12-19 13:53:58 UTC) #1
Timothy Loh
On 2014/12/19 13:53:58, mstensho wrote: lgtm
5 years, 11 months ago (2015-01-04 22:44:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816923002/1
5 years, 11 months ago (2015-01-05 01:13:19 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 01:17:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187834

Powered by Google App Engine
This is Rietveld 408576698