src/factory.cc - Issue 816913003: Implement ES6 rest parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 816913003: Implement ES6 rest parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Disable optimization of functions with rest parameters in parser Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index b3779f291af96bf7cefd769c838fc1534aa9a665..1845ac23bf557e8fe33c347021deccfc304463b2 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2219,7 +2219,8 @@ Handle<DebugInfo> Factory::NewDebugInfo(Handle<SharedFunctionInfo> shared) {

Handle<JSObject> Factory::NewArgumentsObject(Handle<JSFunction> callee,

int length) {

- bool strict_mode_callee = is_strict(callee->shared()->language_mode());

+ bool strict_mode_callee = is_strict(callee->shared()->language_mode()) ||

+ !callee->is_simple_parameter_list();

Handle<Map> map = strict_mode_callee ? isolate()->strict_arguments_map()

: isolate()->sloppy_arguments_map();