Implement ES6 rest parameters

src/objects.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 
 #include "src/allocation.h"
@@ skipping 4156 matching lines @@
 
   // Return if contexts are allocated for this scope.
   bool HasContext();
 
   // Return if this is a function scope with "use asm".
   bool IsAsmModule() { return AsmModuleField::decode(Flags()); }
 
   // Return if this is a nested function within an asm module scope.
   bool IsAsmFunction() { return AsmFunctionField::decode(Flags()); }
 
+  bool IsSimpleParameterList() {
+    return IsSimpleParameterListField::decode(Flags());
+  }
+
   // Return the function_name if present.
   String* FunctionName();
 
   // Return the name of the given parameter.
   String* ParameterName(int var);
 
   // Return the name of the given local.
   String* LocalName(int var);
 
   // Return the name of the given stack local.
@@ skipping 137 matching lines @@
 
   // Properties of scopes.
   class ScopeTypeField : public BitField<ScopeType, 0, 4> {};
   class CallsEvalField : public BitField<bool, 4, 1> {};
   STATIC_ASSERT(LANGUAGE_END == 3);
   class LanguageModeField : public BitField<LanguageMode, 5, 2> {};
   class FunctionVariableField : public BitField<FunctionVariableInfo, 7, 2> {};
   class FunctionVariableMode : public BitField<VariableMode, 9, 3> {};
   class AsmModuleField : public BitField<bool, 12, 1> {};
   class AsmFunctionField : public BitField<bool, 13, 1> {};
+  class IsSimpleParameterListField : public BitField<bool, 13, 1> {};

[arv (Not doing code reviews), 2015/02/12 21:48:43]

14 or AsmFunctionField::kNext

[caitp (gmail), 2015/02/12 22:12:03]

Oops, fixed! I'm going with the kNext option, seems less error-prone

 
   // BitFields representing the encoded information for context locals in the
   // ContextLocalInfoEntries part.
   class ContextLocalMode:      public BitField<VariableMode,         0, 3> {};
   class ContextLocalInitFlag:  public BitField<InitializationFlag,   3, 1> {};
   class ContextLocalMaybeAssignedFlag
       : public BitField<MaybeAssignedFlag, 4, 1> {};
 };
 
 
@@ skipping 2668 matching lines @@
 
   // Source size of this function.
   int SourceSize();
 
   // Calculate the instance size.
   int CalculateInstanceSize();
 
   // Calculate the number of in-object properties.
   int CalculateInObjectProperties();
 
+  inline bool is_simple_parameter_list();
+
   // Dispatched behavior.
   DECLARE_PRINTER(SharedFunctionInfo)
   DECLARE_VERIFIER(SharedFunctionInfo)
 
   void ResetForNewContext(int new_ic_age);
 
   DECLARE_CAST(SharedFunctionInfo)
 
   // Constants.
   static const int kDontAdaptArgumentsSentinel = -1;
@@ skipping 486 matching lines @@
   // not have one. Note that this method does not copy the initial map
   // if it has one already, but simply replaces it with the new value.
   // Instances created afterwards will have a map whose [[class]] is
   // set to 'value', but there is no guarantees on instances created
   // before.
   void SetInstanceClassName(String* name);
 
   // Returns if this function has been compiled to native code yet.
   inline bool is_compiled();
 
+  // Returns `false` if formal parameters include rest parameters, optional
+  // parameters, or destructuring parameters.
+  // TODO(caitp): make this a flag set during parsing
+  inline bool is_simple_parameter_list();
+
   // [next_function_link]: Links functions into various lists, e.g. the list
   // of optimized functions hanging off the native_context. The CodeFlusher
   // uses this link to chain together flushing candidates. Treated weakly
   // by the garbage collector.
   DECL_ACCESSORS(next_function_link, Object)
 
   // Prints the name of the function using PrintF.
   void PrintName(FILE* out = stdout);
 
   DECLARE_CAST(JSFunction)
@@ skipping 3417 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_