It2Me Confirmation Dialog

remoting/host/it2me/it2me_confirmation_dialog_proxy.h

Index: remoting/host/it2me/it2me_confirmation_dialog_proxy.h
diff --git a/remoting/host/it2me/it2me_confirmation_dialog_proxy.h b/remoting/host/it2me/it2me_confirmation_dialog_proxy.h
new file mode 100644
index 0000000000000000000000000000000000000000..396ab5fbf8947fdaaf3e3fa2d5ea4faabc2aa438
--- /dev/null
+++ b/remoting/host/it2me/it2me_confirmation_dialog_proxy.h
@@ -0,0 +1,59 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_IT2ME_IT2ME_CONFIRMATION_DIALOG_PROXY_H_
+#define REMOTING_HOST_IT2ME_IT2ME_CONFIRMATION_DIALOG_PROXY_H_
+
+#include "base/callback.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
+#include "base/single_thread_task_runner.h"
+#include "base/threading/non_thread_safe.h"
+#include "remoting/host/it2me/it2me_confirmation_dialog.h"
+
+namespace remoting {
+
+class It2MeConfirmationDialogProxy {

[Sergey Ulanov, 2014/12/19 03:16:19]

should this implement It2MeConfirmationDialog?

[dcaiafa, 2014/12/20 00:22:00]

Done.

+ public:
+  It2MeConfirmationDialogProxy(
+      scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
+      scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner,
+      scoped_ptr<It2MeConfirmationDialog> dialog);
+
+  ~It2MeConfirmationDialogProxy();
+
+  void Show(const It2MeConfirmationDialog::ResultCallback& callback);
+
+ private:
+  class Core : public base::RefCountedThreadSafe<Core> {

[Sergey Ulanov, 2014/12/19 03:16:19]

don't need this to be ref-counted. Use DeleteSoon() to delete the Core on the UI
thread and the proxy is deleted and a weak_ptr to post tasks from core to the
proxy.

[Sergey Ulanov, 2014/12/19 03:16:19]

this can be moved to the .cc file.

[dcaiafa, 2014/12/20 00:22:00]

Done.

[dcaiafa, 2014/12/20 00:22:00]

Done.

+   public:
+    Core(scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
+         scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner,
+         base::WeakPtr<It2MeConfirmationDialogProxy> parent,
+         scoped_ptr<It2MeConfirmationDialog> dialog);
+
+    void Show();
+
+   private:
+    friend base::RefCountedThreadSafe<Core>;
+
+    ~Core();
+    void ReportResult(It2MeConfirmationDialog::Result result);
+
+    scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
+    scoped_refptr<base::SingleThreadTaskRunner> caller_task_runner_;
+    base::WeakPtr<It2MeConfirmationDialogProxy> parent_;
+    scoped_ptr<It2MeConfirmationDialog> dialog_;
+  };
+
+  void ReportResult(It2MeConfirmationDialog::Result result);
+
+  scoped_refptr<Core> core_;
+  It2MeConfirmationDialog::ResultCallback callback_;
+  base::WeakPtrFactory<It2MeConfirmationDialogProxy> weak_factory_;
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_IT2ME_IT2ME_CONFIRMATION_DIALOG_PROXY_H_