Added HostedAppLaunch for testing hosted app shims on Mac.

Added HostedAppLaunch for testing hosted app shims on Mac.

These tests check that opening the app will start the shim and vice
versa. Similarly, quitting the shim will close the app windows and
closing the app windows will quit the shim.

BUG=437137
Committed: https://crrev.com/399b92a279170cc76e5bb686ca3b35414d4a049a
Cr-Commit-Position: refs/heads/master@{#309382}

[mitchellj, 2014-12-18 23:58:19]

mitchelljones@chromium.org changed reviewers:
+ jackhou@chromium.org

[jackhou1, 2014-12-19 04:22:02]

lgtm

https://codereview.chromium.org/816893002/diff/1/chrome/browser/apps/app_shim...
File chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm (right):

https://codereview.chromium.org/816893002/diff/1/chrome/browser/apps/app_shim...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:176: void
ResetObservation() { observed_ = false; }
Instead of reseting it in the middle, maybe have a WaitUntilAdded and
WaitUntilRemoved, and similarly |observed_add_| and |observed_remove_|. That way
the Wait is not ambiguous either.

[mitchellj, 2014-12-19 05:04:58]

https://codereview.chromium.org/816893002/diff/1/chrome/browser/apps/app_shim...
File chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm (right):

https://codereview.chromium.org/816893002/diff/1/chrome/browser/apps/app_shim...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:176: void
ResetObservation() { observed_ = false; }
On 2014/12/19 04:22:01, jackhou1 wrote:
> Instead of reseting it in the middle, maybe have a WaitUntilAdded and
> WaitUntilRemoved, and similarly |observed_add_| and |observed_remove_|. That
way
> the Wait is not ambiguous either.

Done.

[mitchellj, 2014-12-19 05:05:25]

mitchelljones@chromium.org changed reviewers:
+ tapted@chromium.org

[mitchellj, 2014-12-19 05:05:25]

Hi Trent, could you please review these tests? Thanks.

[tapted, 2014-12-19 05:34:19]

can you add a BUG=? Just the one for the feature should be fine.

Then lgtm % nits.

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
File chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm (right):

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:161:
HostedAppBrowserListObserver(const std::string& app_id)
nit: explicit

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:210: };
nit: DISALLOW_COPY_AND_ASSIGN(HostedAppBrowserListObserver)

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:290: return
NULL;
nit: nullptr

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:399:
[base::mac::ObjCCastStrict<NSRunningApplication>(
nit: usually we don't bother casting things that return `id` if we're just
calling objc methods on them. i.e. just the following should work:

[[running_shim objectAtIndex:0] terminate];

[mitchellj, 2014-12-21 22:39:44]

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
File chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm (right):

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:161:
HostedAppBrowserListObserver(const std::string& app_id)
On 2014/12/19 05:34:19, tapted wrote:
> nit: explicit

Done.

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:210: };
On 2014/12/19 05:34:19, tapted wrote:
> nit: DISALLOW_COPY_AND_ASSIGN(HostedAppBrowserListObserver)

Done.

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:290: return
NULL;
On 2014/12/19 05:34:19, tapted wrote:
> nit: nullptr

Done.

https://codereview.chromium.org/816893002/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm:399:
[base::mac::ObjCCastStrict<NSRunningApplication>(
On 2014/12/19 05:34:19, tapted wrote:
> nit: usually we don't bother casting things that return `id` if we're just
> calling objc methods on them. i.e. just the following should work:
> 
> [[running_shim objectAtIndex:0] terminate];

Using this instead seems to throw some compiler errors:

app_shim_interactive_uitest_mac.mm:401:5: error: multiple methods named
'terminate' found
    [[running_shim objectAtIndex:0] terminate];
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NSTask.h:60:1: note: using
- (void)terminate; // Not always possible. Sends SIGTERM.
^~~~~~~~~~~~~~~~~~
NSRunningApplication.h:135:1: note: also found
- (BOOL)terminate;

So I'll leave it casted for now. This is also consistent with the way the tests
are done elsewhere in the file.

[mitchellj, 2014-12-22 00:42:13]

The CQ bit was checked by mitchelljones@chromium.org

[commit-bot: I haz the power, 2014-12-22 00:43:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/816893002/40001

[commit-bot: I haz the power, 2014-12-22 01:29:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-22 01:30:20]

Patchset 3 (id:??) landed as
https://crrev.com/399b92a279170cc76e5bb686ca3b35414d4a049a
Cr-Commit-Position: refs/heads/master@{#309382}