Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 816833006: Add explicit support for discovering the GpuProcess to Telemetry's 'Model'. (Closed)

Created:
5 years, 11 months ago by Andrew Hayden (chromium.org)
Modified:
5 years, 11 months ago
Reviewers:
tonyg, Sami
CC:
chromium-reviews, tfarina, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add explicit support for discovering the GpuProcess to Telemetry's 'Model'. BUG= Committed: https://crrev.com/f6ade006723de6a100b6dd6b545cb5916b197925 Cr-Commit-Position: refs/heads/master@{#311486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/telemetry/telemetry/timeline/model.py View 2 chunks +11 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer.py View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Andrew Hayden (chromium.org)
PTAL
5 years, 11 months ago (2015-01-14 15:06:25 UTC) #2
Sami
lgtm, thanks!
5 years, 11 months ago (2015-01-14 15:39:00 UTC) #3
Andrew Hayden (chromium.org)
On 2015/01/14 15:39:00, Sami wrote: > lgtm, thanks! FWIW I've verified this is working with ...
5 years, 11 months ago (2015-01-14 15:40:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816833006/1
5 years, 11 months ago (2015-01-14 15:44:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 16:13:05 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f6ade006723de6a100b6dd6b545cb5916b197925 Cr-Commit-Position: refs/heads/master@{#311486}
5 years, 11 months ago (2015-01-14 16:14:11 UTC) #8
Ryan Hamilton
5 years, 11 months ago (2015-01-15 00:44:05 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/819643006/ by rch@chromium.org.

The reason for reverting is: Since this CL landed, we've been seeing flakes in
Mac 10.9 telemetry_unittests. It's not clear that this CL is responsible, but
the timing is suspicious.

Recent 10.9 failures:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)

Detailed log:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2....

Powered by Google App Engine
This is Rietveld 408576698