chrome/browser/prefs/pref_metrics_service.h - Issue 81683002: Prevent GetDeviceId from invoking its callback multiple times in failure cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_metrics_service.h

Issue 81683002: Prevent GetDeviceId from invoking its callback multiple times in failure cases. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: +TODO Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/music_manager_private/device_id.cc ('k') | chrome/browser/prefs/pref_metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/pref_metrics_service.h

diff --git a/chrome/browser/prefs/pref_metrics_service.h b/chrome/browser/prefs/pref_metrics_service.h

index d9b44423d3a48a44e323bfbe60bacedb50a9d284..c776b07f2a8d56b74f9fb5907d3df77b209fdff3 100644

--- a/chrome/browser/prefs/pref_metrics_service.h

+++ b/chrome/browser/prefs/pref_metrics_service.h

@@ -125,6 +125,9 @@ class PrefMetricsService : public BrowserContextKeyedService {

std::string device_id_;

const char** tracked_pref_paths_;

const int tracked_pref_path_count_;

+ // TODO(gab): preprocessor define this member out on builds that don't use

+ // DCHECKs (http://crbug.com/322713).

bool checked_tracked_prefs_;

PrefChangeRegistrar pref_registrar_;

« no previous file with comments | « chrome/browser/extensions/api/music_manager_private/device_id.cc ('k') | chrome/browser/prefs/pref_metrics_service.cc » ('j') | no next file with comments »