Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 816813003: Make android jinja wrapper work on utf-8 templates (Closed)

Created:
5 years, 11 months ago by tsniatowski
Modified:
5 years, 11 months ago
Reviewers:
cjhopman, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make android jinja wrapper work on utf-8 templates Jinja2 defaults to utf-8 for templates... unless the template is loaded using env.from_string. Since we process manifest xml files which are declared utf-8, the wrapper should treat them as utf-8 properly. BUG= Committed: https://crrev.com/dad6da460d13947b90750195bc4957349e670e61 Cr-Commit-Position: refs/heads/master@{#312352}

Patch Set 1 #

Patch Set 2 : Use codecs.open instead of str.decode/encode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/android/gyp/jinja_template.py View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
tsniatowski
5 years, 11 months ago (2015-01-09 13:34:40 UTC) #2
newt (away)
I'd suggest using the codecs module to read/write the file using UTF-8. Example here: http://stackoverflow.com/a/19591815/598094
5 years, 11 months ago (2015-01-12 19:03:00 UTC) #3
tsniatowski
On 2015/01/12 19:03:00, newt wrote: > I'd suggest using the codecs module to read/write the ...
5 years, 11 months ago (2015-01-19 06:16:59 UTC) #4
newt (away)
lgtm
5 years, 11 months ago (2015-01-20 16:22:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816813003/20001
5 years, 11 months ago (2015-01-20 17:14:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37023) Try jobs failed on following ...
5 years, 11 months ago (2015-01-20 17:22:01 UTC) #9
cjhopman
lgtm
5 years, 11 months ago (2015-01-20 20:57:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816813003/20001
5 years, 11 months ago (2015-01-20 20:58:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37023)
5 years, 11 months ago (2015-01-20 20:59:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816813003/20001
5 years, 11 months ago (2015-01-21 06:46:12 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 14:17:39 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:18:33 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dad6da460d13947b90750195bc4957349e670e61
Cr-Commit-Position: refs/heads/master@{#312352}

Powered by Google App Engine
This is Rietveld 408576698